FFS-3880: delete on exit when creating an activity#1550
Open
FFS-3880: delete on exit when creating an activity#1550
Conversation
daphnegold
reviewed
Apr 3, 2026
Contributor
daphnegold
left a comment
There was a problem hiding this comment.
This is great so far! Let me know what you think about adding logic for which flow owns the deletions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FFS-3880
Changes
Now, when you exit the activity flow during creation only, the records we created along the way will be deleted. As such, you will no longer see a representation of the incomplete activity on the Activity Hub when you return to it. This should work whether you hit the exit button, the back button, or even navigate to the hub manually via URL.
Context for reviewers
I considered doing this by modifying the behavior of the exit button in the header; we could react to the lack of from_edit to recognize when we're in a creation flow, then issue a delete command. But I chose this way because it works even with the back button and there were fewer necessary changes. I'm open to feedback on this choice, though.
Testing instructions
Acceptance testing
Preview environment